Skip to content

Conversation

@MaxPalmer-UH
Copy link
Contributor

…olatedFrameSize if the device is null. FixedUpdate will no longer make these calls without a valid connection too. These methods will log a warning once per session if called with a null device

Summary

FixedUpdate in the LeapServiceProvider will attempt to call InterpolateFrame and GetInterplatedFrameSize functions even if it doesn't have a valid device or connection. Update will attempt to call these if it doesn't have a valid device. Change these paths to require a valid connection and a device.

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Test Cycle

Checked this works on Windows/MacOS with a variety of hardware.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

TODO

Max Palme and others added 2 commits October 15, 2025 14:44
…olatedFrameSize if the device is null. FixedUpdate will no longer make these calls without a valid connection too. These methods will log a warning once per session if called with a null device
Added changelog comments
@ultraleap ultraleap deleted a comment from Miazyy Nov 13, 2025
@ultraleap ultraleap deleted a comment from Miazyy Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants